Skip to content

Remove React.createFactory #27798

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Remove React.createFactory #27798

merged 2 commits into from
Mar 29, 2024

Conversation

kassens
Copy link
Member

@kassens kassens commented Dec 6, 2023

React.createFactory has been long deprecated. This removes it for the next release.

@kassens kassens requested a review from gnoff December 6, 2023 15:43
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 6, 2023
@react-sizebot
Copy link

react-sizebot commented Mar 13, 2024

Comparing: 6cd6ba7...73690c0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.12 kB 177.12 kB = 55.06 kB 55.06 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.96 kB 172.96 kB = 53.92 kB 53.92 kB
facebook-www/ReactDOM-prod.classic.js = 592.70 kB 592.70 kB = 103.96 kB 103.96 kB
facebook-www/ReactDOM-prod.modern.js = 574.39 kB 574.39 kB = 100.99 kB 100.99 kB
test_utils/ReactAllWarnings.js Deleted 65.18 kB 0.00 kB Deleted 16.30 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react/umd/react.production.min.js = 13.57 kB 13.49 kB = 5.16 kB 5.13 kB
oss-experimental/react/umd/react.profiling.min.js = 13.57 kB 13.49 kB = 5.16 kB 5.13 kB
oss-stable/react/umd/react.production.min.js = 12.68 kB 12.59 kB = 4.88 kB 4.84 kB
oss-stable/react/umd/react.profiling.min.js = 12.68 kB 12.59 kB = 4.88 kB 4.84 kB
oss-stable-semver/react/umd/react.production.min.js = 12.65 kB 12.57 kB = 4.86 kB 4.82 kB
oss-stable-semver/react/umd/react.profiling.min.js = 12.65 kB 12.57 kB = 4.86 kB 4.82 kB
facebook-www/React-profiling.classic.js = 22.08 kB 21.92 kB = 5.49 kB 5.46 kB
facebook-www/React-prod.classic.js = 21.64 kB 21.48 kB = 5.41 kB 5.37 kB
facebook-react-native/react/cjs/React-prod.js = 21.29 kB 21.12 kB = 5.35 kB 5.31 kB
oss-experimental/react/cjs/react.production.min.js = 10.02 kB 9.95 kB = 3.71 kB 3.67 kB
oss-stable/react/cjs/react.production.min.js = 9.07 kB 8.99 kB = 3.40 kB 3.37 kB
oss-stable-semver/react/cjs/react.production.min.js = 9.05 kB 8.97 kB = 3.38 kB 3.34 kB
oss-experimental/react/umd/react.development.js = 125.12 kB 123.76 kB = 32.21 kB 31.85 kB
oss-stable/react/umd/react.development.js = 123.81 kB 122.45 kB = 31.52 kB 31.18 kB
oss-stable-semver/react/umd/react.development.js = 123.78 kB 122.42 kB = 31.50 kB 31.15 kB
facebook-www/React-dev.classic.js = 129.04 kB 127.53 kB = 30.40 kB 30.03 kB
facebook-react-native/react/cjs/React-dev.js = 127.11 kB 125.59 kB = 30.01 kB 29.66 kB
oss-experimental/react/cjs/react.development.js = 102.41 kB 101.12 kB = 27.60 kB 27.26 kB
oss-stable/react/cjs/react.development.js = 101.10 kB 99.80 kB = 26.96 kB 26.62 kB
oss-stable-semver/react/cjs/react.development.js = 101.07 kB 99.78 kB = 26.93 kB 26.59 kB
oss-experimental/react/cjs/react.production.js = 42.16 kB 41.55 kB = 11.64 kB 11.44 kB
oss-stable/react/cjs/react.production.js = 39.33 kB 38.72 kB = 10.89 kB 10.70 kB
oss-stable-semver/react/cjs/react.production.js = 39.30 kB 38.69 kB = 10.86 kB 10.67 kB
test_utils/ReactAllWarnings.js Deleted 65.18 kB 0.00 kB Deleted 16.30 kB 0.00 kB

Generated by 🚫 dangerJS against 73690c0

@gnoff gnoff added the React 19 label Mar 13, 2024
@kassens kassens merged commit 2aed507 into facebook:main Mar 29, 2024
38 checks passed
@kassens kassens deleted the create-factory branch March 29, 2024 20:29
github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
`React.createFactory` has been long deprecated. This removes it for the
next release.

DiffTrain build for [2aed507](2aed507)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
`React.createFactory` has been long deprecated. This removes it for the
next release.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
`React.createFactory` has been long deprecated. This removes it for the
next release.

DiffTrain build for commit 2aed507.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants