Skip to content

Improve flagging of React.cache to remove indirection in bundled code #28263

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Feb 7, 2024

Uses a better technique for conditionally disabling cache on the client

@gnoff gnoff requested a review from acdlite February 7, 2024 00:44
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 7, 2024
@react-sizebot
Copy link

Comparing: 1beb941...264dfba

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.66 kB 176.66 kB = 55.01 kB 55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.65 kB 178.65 kB = 55.59 kB 55.59 kB
facebook-www/ReactDOM-prod.classic.js = 591.78 kB 591.78 kB = 104.44 kB 104.44 kB
facebook-www/ReactDOM-prod.modern.js = 575.53 kB 575.53 kB = 101.54 kB 101.54 kB
test_utils/ReactAllWarnings.js Deleted 67.02 kB 0.00 kB Deleted 16.42 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react/umd/react.production.min.js = 12.81 kB 12.78 kB = 4.95 kB 4.93 kB
oss-experimental/react/umd/react.profiling.min.js = 12.81 kB 12.78 kB = 4.95 kB 4.93 kB
oss-stable/react/umd/react.production.min.js = 11.94 kB 11.91 kB = 4.67 kB 4.65 kB
oss-stable/react/umd/react.profiling.min.js = 11.94 kB 11.91 kB = 4.67 kB 4.65 kB
oss-stable-semver/react/umd/react.production.min.js = 11.91 kB 11.88 kB = 4.64 kB 4.63 kB
oss-stable-semver/react/umd/react.profiling.min.js = 11.91 kB 11.88 kB = 4.64 kB 4.63 kB
oss-experimental/react/cjs/react.production.min.js = 9.07 kB 9.05 kB = 3.42 kB 3.42 kB
oss-stable/react/cjs/react.production.min.js = 8.14 kB 8.12 kB = 3.14 kB 3.13 kB
oss-stable-semver/react/cjs/react.production.min.js = 8.12 kB 8.09 kB = 3.11 kB 3.11 kB
test_utils/ReactAllWarnings.js Deleted 67.02 kB 0.00 kB Deleted 16.42 kB 0.00 kB

Generated by 🚫 dangerJS against 264dfba

@gnoff gnoff merged commit a1ace9d into facebook:main Feb 7, 2024
@gnoff gnoff deleted the improve-cache-fork branch February 7, 2024 01:40
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
…de (#28263)

Uses a better technique for conditionally disabling cache on the client

DiffTrain build for [a1ace9d](a1ace9d)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…de (facebook#28263)

Uses a better technique for conditionally disabling cache on the client
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…de (#28263)

Uses a better technique for conditionally disabling cache on the client

DiffTrain build for commit a1ace9d.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants