-
Notifications
You must be signed in to change notification settings - Fork 48.4k
DevTools: Read context values from context dependencies #28467
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
eps1lon
merged 8 commits into
facebook:main
from
eps1lon:fix/devtools/readContext-context-dependency
Mar 20, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4a69a70
DevTools: Read context values from context dependencies
e9eaac1
Make it explicit that reading from context directly is only supported…
2c0bdc8
Remove special context
0775186
if-else
0df1e46
Ensure backwards compatibility with older reconciler versions
eps1lon 2f5faa4
No memoizedValue before React 18
eps1lon 4c2a435
Keep old control flow
eps1lon 088fb2c
Not all versions of `fiber.dependencies` have `contextDependency.memo…
eps1lon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only for
ReactDebugTools.inspectHooks
where we don't have access to the current fiber (we have tests that would break if we throw just becausecurrentContextDependency
is null).