Update gate pragma to detect global error events #28591

acdlite · 2024-03-19T23:45:02Z

If a global error event is dispatched during a test, Jest reports that test as a failure.

Our @gate pragma feature should account for this — if the gate condition is false, and the global error event is dispatched, then the test should be reported as a success.

The solution is to install an error event handler right before invoking the test function. Because we install our own handler, Jest will not report the test as a failure if a global error event is dispatched; it's conceptually as if we wrapped the whole test event in a try-catch.

If a global error event is dispatched during a test, Jest reports that test as a failure. Our `@gate` pragma feature should account for this — if the gate condition is false, and the global error event is dispatched, then the test should be reported as a success. The solution is to install an error event handler right before invoking the test function. Because we install our own handler, Jest will not report the test as a failure if a global error event is dispatched; it's conceptually as if we wrapped the whole test event in a try-catch.

react-sizebot · 2024-03-20T00:02:03Z

Comparing: 82c6595...ad6b1c1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.83 kB	176.83 kB	=	54.91 kB	54.90 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.26 kB	173.26 kB	=	54.04 kB	54.04 kB
facebook-www/ReactDOM-prod.classic.js	=	594.27 kB	594.27 kB	=	104.44 kB	104.44 kB
facebook-www/ReactDOM-prod.modern.js	=	577.53 kB	577.53 kB	=	101.47 kB	101.47 kB
test_utils/ReactAllWarnings.js	Deleted	66.48 kB	0.00 kB	Deleted	16.26 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.48 kB	0.00 kB	Deleted	16.26 kB	0.00 kB

Generated by 🚫 dangerJS against ad6b1c1

eps1lon · 2024-03-20T00:26:00Z

scripts/jest/setupTests.js

@@ -241,13 +241,30 @@ if (process.env.REACT_CLASS_EQUIVALENCE_TEST) {
    global.Error = ErrorProxy;
  }

-  const expectTestToFail = async (callback, error) => {
+  const expectTestToFail = async (callback, errorToThrowIfTestSucceeds) => {


If a global error event is dispatched during a test, Jest reports that test as a failure. Our `@gate` pragma feature should account for this — if the gate condition is false, and the global error event is dispatched, then the test should be reported as a success. The solution is to install an error event handler right before invoking the test function. Because we install our own handler, Jest will not report the test as a failure if a global error event is dispatched; it's conceptually as if we wrapped the whole test event in a try-catch.

acdlite requested a review from sebmarkbage March 19, 2024 23:45

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 19, 2024

sebmarkbage approved these changes Mar 19, 2024

View reviewed changes

eps1lon approved these changes Mar 20, 2024

View reviewed changes

acdlite merged commit 29a6ca3 into facebook:main Mar 20, 2024

ztanner mentioned this pull request Mar 21, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gate pragma to detect global error events #28591

Update gate pragma to detect global error events #28591

acdlite commented Mar 19, 2024

react-sizebot commented Mar 20, 2024

eps1lon Mar 20, 2024

Update gate pragma to detect global error events #28591

Update gate pragma to detect global error events #28591

Conversation

acdlite commented Mar 19, 2024

react-sizebot commented Mar 20, 2024

Critical size changes

Significant size changes

eps1lon Mar 20, 2024

Choose a reason for hiding this comment