Skip to content

[Fizz][Legacy] Remove renderToNodeStream #28607

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

[Fizz][Legacy] Remove renderToNodeStream #28607

merged 1 commit into from
Mar 27, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Mar 21, 2024 •
edited
Loading

Stacked on #28606

renderToNodeStream has been deprecated since React 18 with a warning indicating users should upgrade to renderToPipeableStream. This change removes renderToNodeStream

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 21, 2024
@gnoff gnoff requested a review from sebmarkbage March 21, 2024 16:00
@gnoff gnoff added the React 19 label Mar 21, 2024
@react-sizebot
Copy link

react-sizebot commented Mar 21, 2024 •
edited
Loading

Comparing: 2b036d3...ad3be49

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.92 kB 176.92 kB = 54.99 kB 54.99 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.10 kB 173.10 kB = 53.94 kB 53.94 kB
facebook-www/ReactDOM-prod.classic.js = 592.31 kB 592.31 kB = 103.83 kB 103.83 kB
facebook-www/ReactDOM-prod.modern.js = 573.20 kB 573.20 kB = 100.71 kB 100.71 kB
oss-experimental/react-dom/server.node.js = 0.74 kB 0.69 kB = 0.27 kB 0.27 kB
oss-stable-semver/react-dom/server.node.js = 0.74 kB 0.69 kB = 0.27 kB 0.27 kB
oss-stable/react-dom/server.node.js = 0.74 kB 0.69 kB = 0.27 kB 0.27 kB
oss-experimental/react-dom/server.browser.js = 0.71 kB 0.65 kB = 0.27 kB 0.26 kB
oss-stable-semver/react-dom/server.browser.js = 0.71 kB 0.65 kB = 0.27 kB 0.26 kB
oss-stable/react-dom/server.browser.js = 0.71 kB 0.65 kB = 0.27 kB 0.26 kB
oss-experimental/react-dom/server.edge.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-stable-semver/react-dom/server.edge.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-stable/react-dom/server.edge.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-experimental/react-dom/server.bun.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-stable-semver/react-dom/server.bun.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-stable/react-dom/server.bun.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
test_utils/ReactAllWarnings.js Deleted 65.26 kB 0.00 kB Deleted 16.32 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom-server.bun.production.min.js = 86.17 kB 85.98 kB = 26.09 kB 26.07 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.min.js = 82.92 kB 82.73 kB = 25.20 kB 25.19 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.min.js = 82.89 kB 82.70 kB = 25.17 kB 25.16 kB
oss-experimental/react-dom/server.node.js = 0.74 kB 0.69 kB = 0.27 kB 0.27 kB
oss-stable-semver/react-dom/server.node.js = 0.74 kB 0.69 kB = 0.27 kB 0.27 kB
oss-stable/react-dom/server.node.js = 0.74 kB 0.69 kB = 0.27 kB 0.27 kB
oss-experimental/react-dom/server.browser.js = 0.71 kB 0.65 kB = 0.27 kB 0.26 kB
oss-stable-semver/react-dom/server.browser.js = 0.71 kB 0.65 kB = 0.27 kB 0.26 kB
oss-stable/react-dom/server.browser.js = 0.71 kB 0.65 kB = 0.27 kB 0.26 kB
oss-experimental/react-dom/server.edge.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-stable-semver/react-dom/server.edge.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-stable/react-dom/server.edge.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-experimental/react-dom/server.bun.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-stable-semver/react-dom/server.bun.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
oss-stable/react-dom/server.bun.js = 0.70 kB 0.65 kB = 0.28 kB 0.27 kB
test_utils/ReactAllWarnings.js Deleted 65.26 kB 0.00 kB Deleted 16.32 kB 0.00 kB

Generated by 🚫 dangerJS against ad3be49

@gnoff
[Fizz][Legacy] Remove renderToNodeStream
ad3be49 
renderToNodeStream has been deprecated since React 18 with a warning indicating users should upgrade to renderToPipeableStream. This change removes renderToNodeStream
@gnoff gnoff force-pushed the remove-rendertonodestream branch from 5084178 to ad3be49 Compare March 27, 2024 18:23
@gnoff gnoff merged commit 8436bcc into facebook:main Mar 27, 2024
38 checks passed
@gnoff gnoff deleted the remove-rendertonodestream branch March 27, 2024 19:02
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
@gnoff
[Fizz][Legacy] Remove renderToNodeStream (#28607)
a0d5dab 
Stacked on #28606

renderToNodeStream has been deprecated since React 18 with a warning
indicating users should upgrade to renderToPipeableStream. This change
removes renderToNodeStream

DiffTrain build for [8436bcc](8436bcc)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gnoff @AndyPengc12
[Fizz][Legacy] Remove renderToNodeStream (facebook#28607)
25d624d 
Stacked on facebook#28606 

renderToNodeStream has been deprecated since React 18 with a warning
indicating users should upgrade to renderToPipeableStream. This change
removes renderToNodeStream
This was referenced Apr 24, 2024
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnoff @react-sizebot @sebmarkbage @facebook-github-bot