Remove errorHydratingContainer #28664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 9f33f69...8d49499 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
force-pushed
the
extraerrors
branch
3 times, most recently
from
2575b55 to
b3eb6b6
Compare
rickhanlonii
approved these changes
Mar 28, 2024
| @@ -32,15 +32,6 @@ module.exports = function shouldIgnoreConsoleError( | |||
| // We haven't finished migrating our tests to use createRoot. | |||
| return true; | |||
| } | |||
| if ( | |||
| TODO_ignoreHydrationErrors && | |||
There was a problem hiding this comment.
Me: wtf is TODO_ignoreHydrationErrors, kill that
checks blame
Me: oh yeah great idea, very smart
sebmarkbage
force-pushed
the
extraerrors
branch
from
b3eb6b6 to
8d49499
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
I originally added this in #21021 but I didn't mention why and I don't quite remember why. Maybe because there were no other message? However at the time the recoverable errors mechanism didn't exist. Today I believe all cases where this happens will trigger another recoverable error. Namely these two: https://github.com/facebook/react/blob/9f33f699e4f832971dc0f2047129f832655a3b6d/packages/react-reconciler/src/ReactFiberBeginWork.js#L1442-L1446 https://github.com/facebook/react/blob/9f33f699e4f832971dc0f2047129f832655a3b6d/packages/react-reconciler/src/ReactFiberBeginWork.js#L2962-L2965 Therefore this is just an extra unnecessary log. DiffTrain build for [323b6e9](323b6e9)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
I originally added this in facebook#21021 but I didn't mention why and I don't quite remember why. Maybe because there were no other message? However at the time the recoverable errors mechanism didn't exist. Today I believe all cases where this happens will trigger another recoverable error. Namely these two: https://github.com/facebook/react/blob/9f33f699e4f832971dc0f2047129f832655a3b6d/packages/react-reconciler/src/ReactFiberBeginWork.js#L1442-L1446 https://github.com/facebook/react/blob/9f33f699e4f832971dc0f2047129f832655a3b6d/packages/react-reconciler/src/ReactFiberBeginWork.js#L2962-L2965 Therefore this is just an extra unnecessary log.
This was referenced Apr 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally added this in #21021 but I didn't mention why and I don't quite remember why. Maybe because there were no other message? However at the time the recoverable errors mechanism didn't exist.
Today I believe all cases where this happens will trigger another recoverable error. Namely these two:
react/packages/react-reconciler/src/ReactFiberBeginWork.js
Lines 1442 to 1446 in 9f33f69
react/packages/react-reconciler/src/ReactFiberBeginWork.js
Lines 2962 to 2965 in 9f33f69
Therefore this is just an extra unnecessary log.