Skip to content

Enable Wave 1 of Feature Flags for React Native #28977

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 3, 2024

Conversation

yungsters
Copy link
Contributor

Summary

We are ready to enable the following feature flags in React Native:

  • enableAsyncActions
  • enableComponentStackLocations
  • enableRenderableContext
  • useModernStrictMode

This will only affect Meta for now. The open source feature flags are already set to __TODO_NEXT_RN_MAJOR__.

How did you test this change?

$ yarn test
$ yarn flow fabric

@react-sizebot
Copy link

Comparing: 4508873...b1e113a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
facebook-www/ReactDOM-prod.classic.js = 591.11 kB 591.11 kB = 103.94 kB 103.94 kB
facebook-www/ReactDOM-prod.modern.js = 567.33 kB 567.33 kB = 100.34 kB 100.34 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 49.75 kB 48.54 kB = 14.18 kB 14.00 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 48.52 kB 47.31 kB = 13.82 kB 13.64 kB
facebook-react-native/react/cjs/React-dev.js = 113.16 kB 110.05 kB = 29.43 kB 28.96 kB
facebook-react-native/react/cjs/React-profiling.js = 22.37 kB 21.68 kB = 5.83 kB 5.69 kB
facebook-react-native/react/cjs/React-prod.js = 21.93 kB 21.25 kB = 5.75 kB 5.61 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.19 kB 6.37 kB = 1.96 kB 1.75 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 5.18 kB 4.53 kB = 1.25 kB 1.13 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 5.18 kB 4.53 kB = 1.25 kB 1.13 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +1.42% 838.34 kB 850.21 kB +1.82% 180.53 kB 183.82 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +1.37% 313.80 kB 318.11 kB +1.64% 55.19 kB 56.09 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +1.30% 338.26 kB 342.67 kB +1.59% 58.71 kB 59.64 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 966.13 kB 962.71 kB = 209.44 kB 208.98 kB
react-native/implementations/ReactFabric-dev.fb.js = 953.20 kB 949.78 kB = 205.71 kB 205.23 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 401.07 kB 398.17 kB = 69.62 kB 69.20 kB
react-native/implementations/ReactFabric-profiling.fb.js = 393.71 kB 390.81 kB = 68.28 kB 67.83 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 373.83 kB 370.93 kB = 65.39 kB 64.91 kB
react-native/implementations/ReactFabric-prod.fb.js = 366.41 kB 363.51 kB = 64.05 kB 63.61 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js = 49.75 kB 48.54 kB = 14.18 kB 14.00 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js = 48.52 kB 47.31 kB = 13.82 kB 13.64 kB
facebook-react-native/react/cjs/React-dev.js = 113.16 kB 110.05 kB = 29.43 kB 28.96 kB
facebook-react-native/react/cjs/React-profiling.js = 22.37 kB 21.68 kB = 5.83 kB 5.69 kB
facebook-react-native/react/cjs/React-prod.js = 21.93 kB 21.25 kB = 5.75 kB 5.61 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 7.19 kB 6.37 kB = 1.96 kB 1.75 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 5.18 kB 4.53 kB = 1.25 kB 1.13 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 5.18 kB 4.53 kB = 1.25 kB 1.13 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against b1e113a

@yungsters yungsters merged commit 1d618a9 into facebook:main May 3, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@yungsters yungsters deleted the rn-flags branch May 4, 2024 04:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants