Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[eslint-plugin-react-hooks] Add flat/recommended config #29770

Closed
wants to merge 1 commit into from
+16 −5
Closed

[eslint-plugin-react-hooks] Add flat/recommended config #29770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions packages/eslint-plugin-react-hooks/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
import RulesOfHooks from './RulesOfHooks';
import ExhaustiveDeps from './ExhaustiveDeps';

export const rules = {
'rules-of-hooks': RulesOfHooks,
'exhaustive-deps': ExhaustiveDeps,
};

export const configs = {
recommended: {
plugins: ['react-hooks'],
Expand All @@ -18,9 +23,15 @@ export const configs = {
'react-hooks/exhaustive-deps': 'warn',
},
},
};

export const rules = {
'rules-of-hooks': RulesOfHooks,
'exhaustive-deps': ExhaustiveDeps,
'flat/recommended': {
plugins: {
'react-hooks': {
rules,
},
},
rules: {
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'warn',
},
Comment on lines +32 to +35
Copy link

@burtek burtek Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is same in recommended and flat/recommended, how about assigning this to a const and reusing in both configs? It's not like the rulessets will differ from each other

},
};