Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[compiler] Repros for missing memoization due to lack of phi type inference #30793

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

…erence

This is a complex case: we not only need phi type inference but also need to be able infer the union of `MixedReadonly | Array`.

[ghstack-poisoned]
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 11:57pm

@josephsavona josephsavona merged commit 97de022 into gh/josephsavona/41/base Aug 23, 2024
19 checks passed
josephsavona added a commit that referenced this pull request Aug 23, 2024
…erence

This is a complex case: we not only need phi type inference but also need to be able infer the union of `MixedReadonly | Array`.

ghstack-source-id: 935088910dd8c210b3253cf8ff1f4b935f5081b7
Pull Request resolved: #30793
@josephsavona josephsavona deleted the gh/josephsavona/41/head branch August 23, 2024 22:25
Akshato07 pushed a commit to Akshato07/-Luffy that referenced this pull request Feb 20, 2025
…erence

This is a complex case: we not only need phi type inference but also need to be able infer the union of `MixedReadonly | Array`.

ghstack-source-id: 935088910dd8c210b3253cf8ff1f4b935f5081b7
Pull Request resolved: facebook/react#30793
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants