-
Notifications
You must be signed in to change notification settings - Fork 47.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[rcr, Flight] Add throwing RSC entrypoint for compiler-runtime #32056
Open
eps1lon
wants to merge
3
commits into
facebook:main
Choose a base branch
from
eps1lon:sebbie/rcr-rsc-throw
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4299d1
to
cf6f1ca
Compare
poteto
approved these changes
Jan 13, 2025
cf6f1ca
to
33c78b3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Alternate to #29057
Closes #31702
Adds a throwing stub to
react-compiler-runtime
andreact/compiler-runtime
if thereact-server
import condition is set that throw:For
react-compiler-runtime
I had to addexports
so this is technically a breaking change. Though I think we consider this only to be used as a Compiler target so anyreact-compiler-runtime/dist/*
orreact-compiler-runtime/src/*
imports are already out of SemVer guarantees I guess?How did you test this change?
Tested
react/compiler-runtime
with CSB artifacts merged with a localyarn build react-compiler-runtime.react-server,react/compiler-runtime
react-compiler-runtime
I just manually checked thatdist/
is as expected: