Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ship enableFabricCompleteRootInCommitPhase #32318

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Ship enableFabricCompleteRootInCommitPhase #32318

merged 1 commit into from
Feb 7, 2025

Conversation

jackpope
Copy link
Contributor

@jackpope jackpope commented Feb 6, 2025

No description provided.

@jackpope jackpope requested a review from kassens February 6, 2025 20:41
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 6, 2025
@react-sizebot
Copy link

Comparing: ff62833...35540d4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.43 kB 515.43 kB = 92.03 kB 92.03 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 558.46 kB 558.46 kB = 99.25 kB 99.25 kB
facebook-www/ReactDOM-prod.classic.js = 636.83 kB 636.83 kB = 111.91 kB 111.91 kB
facebook-www/ReactDOM-prod.modern.js = 627.15 kB 627.15 kB = 110.33 kB 110.33 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-profiling.js +0.21% 383.16 kB 383.98 kB +0.14% 65.98 kB 66.08 kB
react-native/implementations/ReactFabric-prod.js +0.20% 357.92 kB 358.66 kB +0.16% 62.27 kB 62.37 kB

Generated by 🚫 dangerJS against b8cca09

@jackpope jackpope merged commit 8759c5c into facebook:main Feb 7, 2025
193 checks passed
@jackpope jackpope deleted the complete-root-in-commit-phase-cleanup branch February 7, 2025 16:12
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
@jackpope
Ship enableFabricCompleteRootInCommitPhase (#32318)
e74ebba 
DiffTrain build for [8759c5c](8759c5c)
@vercel-release-bot vercel-release-bot mentioned this pull request Feb 7, 2025
Merged
jackpope added a commit to jackpope/react that referenced this pull request Feb 20, 2025
@jackpope
Revert "Ship enableFabricCompleteRootInCommitPhase (facebook#32318)"
05d2df4 
This reverts commit 8759c5c.
@jackpope jackpope mentioned this pull request Feb 20, 2025
Merged
jackpope added a commit that referenced this pull request Feb 20, 2025
@jackpope
Revert "Ship enableFabricCompleteRootInCommitPhase (#32318)" (#32434)
885532c 
This reverts commit 8759c5c /
#32318

We discovered that the experiment setup for this was faulty and we need
to re-run as a back test.
github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
@jackpope
Revert "Ship enableFabricCompleteRootInCommitPhase (#32318)" (#32434)
0719d18 
This reverts commit 8759c5c /
#32318

We discovered that the experiment setup for this was faulty and we need
to re-run as a back test.

DiffTrain build for [885532c](885532c)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kassens kassens kassens approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackpope @react-sizebot @kassens @facebook-github-bot