Using Object.is implementation when compare values inside React.PropTypes.oneOf #6132
Conversation
| return x !== 0 || 1 / x === 1 / y; | ||
| } else { | ||
| // Step 6.a: NaN == NaN | ||
| return x !== x && y !== y; |
There was a problem hiding this comment.
eslint emits warnings here
99:12 warning Comparing to itself is potentially pointless no-self-compare
99:23 warning Comparing to itself is potentially pointless no-self-compare
✖ 2 problems (0 errors, 2 warnings)
what should I do here?
There was a problem hiding this comment.
Just disable that warning for the file.
There was a problem hiding this comment.
done and rebased
| * inlined Object.is polyfill to avoid requiring consumers ship their own | ||
| * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is | ||
| */ | ||
| function is(x, y) { |
There was a problem hiding this comment.
This should move to a separate file at https://github.com/facebook/react/tree/master/src/shared/stubs
There was a problem hiding this comment.
Nah, just going to do this for now.
chicoxyzzy
force-pushed
the
use_object_is_in_oneof_validate_method
branch
from
8229a5e to
03925f4
Compare
|
@chicoxyzzy updated the pull request. |
| * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is | ||
| */ | ||
| /*eslint-disable no-self-compare*/ | ||
| function is(x, y) { |
There was a problem hiding this comment.
This seems like a weird place to define a polyfill. Seems like we should do something more analogous to https://github.com/facebook/react/blob/master/src/shared/stubs/Object.assign.js
There was a problem hiding this comment.
This is intentional and requested by me due to conversations had with @sebmarkbage a couple months ago, don't worry about it. We can deal with figuring out the polyfill story later.
|
Thanks! |
…ate_method Using Object.is implementation when compare values inside React.PropTypes.oneOf
implementation of #6131