Remove unused export from DOMChildrenOperations #6301
Merged
+0
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the only usage of
DOMChildrenOperations.updateTextContent()
was removed in #5753. More specifically, #5753 started usingreplaceDelimitedText()
instead, which it added in the same commit.setTextContent()
itself is still used insideDOMChildrenOperations.processUpdates()
—it’s just that there is no need to re-export it fromDOMChildrenOperations
now.Due Diligence
No
DOMChildrenOperations.updateTextContent
calls in the codebase:Existing matches of
updateTextContent
refer to a function defined onReactMultiChild
rather than the one exported fromDOMChildrenOperations
:It appears that this is safe to remove.
Reviewers
@sebmarkbage @spicyj