Use loose-envify instead of envify #6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| var envify = require('envify/custom'); | |||
| var envify = require('loose-envify/loose-envify'); | |||
There was a problem hiding this comment.
Can you leave the /custom bit - the API matches envify so we can keep that part the same.
This reduces the number of transitive dependencies and decreases the build time (by ~6% on my machine).
|
@qerub updated the pull request. |
|
Thanks! |
zpao
added a commit
that referenced
this pull request
Mar 21, 2016
Use loose-envify instead of envify
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #6252. This reduces the number of transitive dependencies and decreases the build time (by ~6% on my machine). I've confirmed that the compiled artifacts are identical to those generated by
envify.