Basic SSR support for error boundaries #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Looks good to me but I don’t know about how checkpoint abstraction is supposed to be used so deferring to @sebmarkbage. |
|
I don’t see any issues with this, and it fixes a crash, so let’s get it in. |
|
I’m tagging as 15.0.x to emphasize it’s a patch, but we can probably rename this to 15.1.x after 15.1 alpha is shipped as won’t do more 15.0.x releases. |
zpao
pushed a commit
that referenced
this pull request
May 10, 2016
(cherry picked from commit 96cb8c5)
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic SSR support for error boundaries. Fixes #6689.