Improve error message for components in bad states (missing instance) #6990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -509,6 +509,12 @@ var ReactCompositeComponentMixin = { | |||
| return; | |||
There was a problem hiding this comment.
I guess we actually already fail silently here (unset in the same place as ._instance). So we don't need this check.
There was a problem hiding this comment.
Oh yeah, will remove.
|
lgtm, feel free to "squash and merge" |
ghost
added
the
yungsters
force-pushed
the
missing-instance
branch
from
95fd9b3 to
b2792db
Compare
|
@yungsters updated the pull request. |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
…facebook#6990) (cherry picked from commit 7988aca)
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In unknown circumstances (possible due to errors thrown elsewhere), it is possible for React components to enter a bad state where
this._instanceis unset but component state change can continue to happen. This leads to unhelpful error messages like:This adds invariants that assert
this._instanceexists. If the component is in a bad state, we will now instead warn with a more descriptive error message and — more importantly — the component's name.