Change trackedTouchCount invariant into a console.error
#7400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
👍 |
|
Hmm... Travis CI failed, but the failure does not seem relevant. Merge anyway? |
|
Oh, never mind. It was a lint warning, will fix. |
zpao
pushed a commit
that referenced
this pull request
Aug 12, 2016
* Change `trackedTouchCount` invariant into a console.error * Fix ResponderEventPlugin lint warning (cherry picked from commit 0fb8feb)
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing to
ResponderEventPluginwhat #7143 did toResponderTouchHistoryStore. This changes the invariant that currently fatals React Native environments when touch events are misfired to instead fail gracefully viaconsole.error.Reviewers: @spicyj, @jingc
Test Plan:
Ran
grunt testandflow ./srcsuccessfully.