[Fiber] Support SVG #8475
[Fiber] Support SVG #8475
Conversation
Instead of keeping a stack, we let the renderer keep track of the current namespace.
gaearon
force-pushed
the
svg-fiber-take-two
branch
from
41b3452 to
d52fc5c
Compare
|
Like we talked about, this needs to support nested SVG tags. Another case is |
| @@ -268,6 +272,7 @@ module.exports = function<T, P, I, TI, C>( | |||
| // Abort and don't process children yet. | |||
| return null; | |||
| } else { | |||
| pushHostContext(workInProgress.type); | |||
There was a problem hiding this comment.
Should we pass props too? We have cases like props.is where props determine the type. I could imagine this being useful.
There was a problem hiding this comment.
Let's pass when we need them?
gaearon
force-pushed
the
svg-fiber-take-two
branch
from
4572fd0 to
50bfa83
Compare
We allocate an array with one number, and increment it on any nested <svg>. We add a new counter to the array when we encounter a <foreignObject>. The counter lets us avoid a stack for nested <svg>s in the general case.
gaearon
force-pushed
the
svg-fiber-take-two
branch
from
f8e1076 to
530eb7a
Compare
The mutable state we introduced above becomes irrelevant whenever we push a portal because a portal represents a different DOM tree. We store a snapshot of this state and restore it when the portal is popped.
|
Thanks for exploring this option. This is getting pretty complicated as well. How do you feel about reverting back to the one that uses a stack for the host namespace and document? Then we can unify that stack with the context stack later on like we talked about. I feel like a generic stack solution seems pretty useful for a lot of things. |
|
Yeah to be honest I have lost track of what's going on here completely. :-) Do you want to get back to #8417 as it was, or do you have some changes to it in mind? |
|
We can go back to #8417 but let's use a stack for the portal context (container) instead of storing it on the portal. Then we can iterate from there to unify the stacks. |
Replaces #8417.
Instead of keeping a stack, we're notifying the renderer when the work begins and ends.
This lets DOM renderer avoid the stack because namespace logic is not complex.
This is not done yet (missing portals and unwinding on error handling) but I want to get early feedback on the approach.