Skip to content

Delete fiveArgumentPooler #8597

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

davidrbright
Copy link
Contributor

@davidrbright davidrbright commented Dec 18, 2016

Fixes #8596 I found no referenced use of fiveArgumentPooler. Deleted the function, and ran all tests without issue. Current search of fiveArgumentPooler Here.

CLA signed.

@aweary
Copy link
Contributor

aweary commented Dec 19, 2016

@spicyj is this fine with you?

@sophiebits
Copy link
Collaborator

Yup.

Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfrownfelter thanks!

@aweary aweary added this to the 15-next milestone Dec 20, 2016
@aweary aweary merged commit b106ca0 into facebook:master Dec 20, 2016
@davidrbright
Copy link
Contributor Author

No problem!

@davidrbright davidrbright deleted the delete-fiveArgumentPooler branch December 20, 2016 06:25
@gaearon gaearon modified the milestones: 15-hipri, 15-lopri, 15.4.2 Jan 6, 2017
gaearon pushed a commit that referenced this pull request Jan 6, 2017
(cherry picked from commit b106ca0)
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants