Resolve #8656 WebComponent 1.0 support. #8657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a straightforward update of the WebComponent example to match the final 1.0 specification. To meet 1.0 spec, class syntax must be used. I'm unsure of any paths forward to maintaing support for old browsers while also supporting new ones, short of feature detection & having two codepaths.
And lint a ; that followed examples/webcomponent's class XSearch.
|
@rektide the only alternative I can think of is using a |
|
You can transpile down to ES5 (to support old browsers) and include the custom-elements-es5-adapter to support those browsers with native v1 Custom Element support. |
|
We've since updated this. Thanks for PR! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a straightforward update of the WebComponent example to match the final WebComponent 1.0 specification, which mandates ES6 Class syntax.
I'm unsure of any paths forward to maintaining support for old browsers while also supporting new ones, short of feature detection & having two separate codepaths. The situation in the aftermath of #8656 is un-ideal.
This PR depends on cdnjs adding the custom-element polyfill. Those changes are tracked in cdnjs/cdnjs#10108