This repository has been archived by the owner on Feb 1, 2025. It is now read-only.
Add try/catch helper to fix #148 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnordlund
force-pushed
the
issue-148-try-catch-helper
branch
3 times, most recently
from
6abfb9b to
f65cbf5
Compare
|
That Travis failure is not your fault, by the way. |
|
Any word on this? I've been wanting to take a performance pass over Regenerator and this is the first thing that came to mind. |
maxnordlund
force-pushed
the
issue-148-try-catch-helper
branch
from
f65cbf5 to
f1062ad
Compare
|
Just rebased of master, should be cleanly mergeable. |
|
Have any idea how much this helps performance? |
|
I guess it depends, and without some sort of benchmark it's difficult to say. But this is an optimization that bluebird uses, and is also mentioned on html5rocks. |
benjamn
added a commit
that referenced
this pull request
Jan 13, 2015
Add try/catch helper to fix #148.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first alternativ in #148, e.g. use a helper function for all try catch in the runtime.