Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Group trait overhaul part 2 #53

Merged
merged 11 commits into from
Jan 21, 2022
Merged

Group trait overhaul part 2 #53

merged 11 commits into from
Jan 21, 2022

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jan 19, 2022 •
edited
Loading

Follow-up of #52.

  • Remove our implementation of expand_message_xmd and use ExpandMsgXmd of elliptic-curve instead.
  • Update MSRV to 1.57 and Rust edition to 2021
  • Re-introduce CipherSuite and move SUITE_ID to there. This allows consumers to implement their own group and hash combination and assign a custom suite id.
  • Introduce types-defs that represent the serialization length of voprf types.
  • Blanket-implement Group for RustCrypto Curves.
  • Remove custom Group implementation for NistP256.
  • Rename ristretto255_* crate features to ristretto255-*.

We should probably properly document CipherSuite and the ristretto255-ciphersuite crate feature. I hope you like these changes @kevinlewi, I couldn't find any other way to properly do this.

This is still waiting for RustCrypto/traits#906 and RustCrypto/elliptic-curves#515.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2022
@daxpedda daxpedda force-pushed the group-trait-3 branch 3 times, most recently from 9b3fcb8 to ba6ac7a Compare January 19, 2022 12:55
@daxpedda daxpedda changed the title Group trait overhaul take 2 Group trait overhaul part 2 Jan 21, 2022
@daxpedda
Copy link
Contributor Author

CI failures have nothing to do with the PR, just connection issues while updating Rust.

@daxpedda daxpedda mentioned this pull request Jan 21, 2022
Merged
kevinlewi
kevinlewi approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@kevinlewi kevinlewi merged commit 16e072d into facebook:main Jan 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kevinlewi kevinlewi kevinlewi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxpedda @kevinlewi @facebook-github-bot