General improvements #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
kevinlewi
approved these changes
Mar 5, 2022
|
I only left it in draft mode because I planned to add more stuff until I finish facebook/opaque-ke#268. I can take it out if you prefer, feel free to merge it if you want it out of the way too. |
|
It should be fine to leave this in draft for now, then. Thanks for the clarification! |
|
(@daxpedda: Update from my previous comment: I will be happy to push out the next version once this PR is landed, so feel free to take it out of draft mode if you think it is ready for re-review + merge) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some improvements that came to mind while I was working on opaque-ke:
utiltocommon, as instead of utility functions this now contains a lot of common functionality between the OPRF modes.hash_to_scalarandhash_to_groupto only what's needed, now that we don't pass inModeanymore.DeriveKeyPairis thrown away in the OPRF mode, so I split the function up to not unnecessary generate a public key, improving the performance a bit.Ristretto255implementations.