Fix JS build on Windows #1648
Closed
Fix JS build on Windows #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D56230965 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 17, 2024
Summary: Node made a breaking change in a security release for 18/20 where `spawn()` no longer loads `.bat` files by default. nodejs/node@69ffc6d. Execute command in shell. Differential Revision: D56230965
NickGerleman
force-pushed
the
export-D56230965
branch
from
90af442 to
f2ae83f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56230965 |
Summary: Node made a breaking change in a security release for 18/20 where `spawn()` no longer loads `.bat` files by default. nodejs/node@69ffc6d. Execute command in shell. Differential Revision: D56230965
NickGerleman
force-pushed
the
export-D56230965
branch
from
f2ae83f to
362633a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56230965 |
|
This pull request has been merged in c0239e3. |
NickGerleman
added a commit
that referenced
this pull request
Apr 19, 2024
Summary: Pull Request resolved: #1648 Node made a breaking change in a security release for 18/20 where `spawn()` no longer loads `.bat` files by default. nodejs/node@69ffc6d. Execute command in shell. Reviewed By: javache Differential Revision: D56230965 fbshipit-source-id: 52e9bd8a76664bd07ea25b6355ac54fcb24cbb9a
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node made a breaking change in a security release for 18/20 where
spawn()no longer loads.batfiles by default. nodejs/node@69ffc6d. Execute command in shell.Differential Revision: D56230965