Enhance streaming_compression examples. #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senhuang42
reviewed
Oct 5, 2021
senhuang42
suggested changes
Oct 5, 2021
marxin
force-pushed
the
streaming-compress-enhance
branch
from
9b1596f to
3b609eb
Compare
|
Thank you for the comments, I made the suggested changes. I like your suggestions. |
|
@senhuang42 May I please ping this? |
senhuang42
approved these changes
Oct 11, 2021
|
I see some tests are failing, can you update the base repo on top of which this branch sits to the latest dev branch and then force push onto this PR again? |
Add level argument to the first test and be more verbose about used compression level and number of threads.
marxin
force-pushed
the
streaming-compress-enhance
branch
from
3b609eb to
926d470
Compare
|
Sure, I've just done that. |
Cyan4973
approved these changes
Oct 12, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add level argument to the first test and be more verbose about
used compression level and number of threads.