Fix Up #2659; Build libzstd.pc Whenever Building the Lib on Unix #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the libzstd.pc target to the lib target in lib/Makefile, which makes it inherit LDFLAGS_DYNLIB from the lib-mt target. This allows us to add a Libs.private field to libzstd.pc which gets conditionally populated with '-pthread'. The 1.5.0 release notes mention that the static library isn't multi-threaded by default, due to concern for people building static binaries with libzstd: Now the dynamic library supports multi-threaded compression by default. Note that this property is not extended to the static library because doing so would have impacted the build script of existing client applications (requiring them to add -pthread to their recipe), thus potentially breaking their build. To get closer to being able to enable multi-threading for all library builds by default, this commit makes it so that any libzstd consumer using pkg-config gets the correct flags. We also fix the indentation of the rule for libzstd.pc and move it outside the if/endif block for install rules (which uses a list of OSs where the rules were validated), so the rule is available for all users of the 'lib*' targets.
[lib] Fix libzstd.pc for lib-mt builds
|
Curiously, none of the GitHub Actions have run... Not sure why that is. |
Cyan4973
approved these changes
Dec 8, 2021
felixhandte
force-pushed
the
pkg-config-fix
branch
from
bdf8c83 to
9f1dee8
Compare
terrelln
approved these changes
Dec 8, 2021
|
@felixhandte thank you for your fix and for merging it! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #2659 to add
-pthreadtolibzstd.pcwhen the library is built with multithreading. It also promotes the.pcfile to be built whenever the library is built (on Unix--unlike the original PR which builds it everywhere).