Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

x32 compatibility #2922

Merged
merged 2 commits into from
Dec 11, 2021
Merged

x32 compatibility #2922

merged 2 commits into from
Dec 11, 2021

Conversation

Cyan4973
Copy link
Contributor

@Cyan4973 Cyan4973 commented Dec 11, 2021 •
edited
Loading

commit 1 : added x32 compatibility test

note : this test fails, due to ongoing issues with x32

commit 2 : fix the x32 issue

terrelln
terrelln approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@terrelln terrelln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the correct solution to me! Thanks for the fix!

@Cyan4973 Cyan4973 merged commit 252ef86 into dev Dec 11, 2021
@Cyan4973 Cyan4973 deleted the x32 branch January 13, 2023 04:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@terrelln terrelln terrelln approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cyan4973 @terrelln @facebook-github-bot