This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Fixes links accessibility by adding underlines #2497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiopro
reviewed
Jul 16, 2020
claudiopro
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This doesn't solve the issue of accessibility. Links are just one thing, but there are code-blocks, videos, etc. The whole site causes a headache when reading it. |
|
@claudiopro merged this pull request in 5e17cc2. |
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Closes facebookarchive/draft-js#2494 Pull Request resolved: facebookarchive/draft-js#2497 Differential Revision: D22579546 Pulled By: claudiopro fbshipit-source-id: 32d78fd6296013878820084ba8fd1e6343285ccb
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2494