Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Add inherited to search paths #341

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Conversation

arv
Copy link
Contributor

@arv arv commented May 27, 2017

This allows the FacebookSDK path to be configured by the main app
project instead of forcing the app to have a copy in
~Documents/FacebookSDK

This allows the FacebookSDK path to be configured by the main app
project instead of forcing the app to have a copy in
~Documents/FacebookSDK
@ericnograles
Copy link

@arv Thanks, this is exactly what I was looking for! It felt a little dirty to always have to drop the frameworks under ~/Documents/FacebookSDK (especially for CI purposes). Shame they haven't approved this yet though, might have to fork this repo until this PR gets merged in.

Looks like this PR was created back in May -- is anybody still maintaining this library or handling the backlog of PR's?

@jamesjara
Copy link

jamesjara commented Aug 11, 2017

Yes, please we need this, my current solution if works for anybody else is this:

# File: buddybuild_postclone.sh
# Creating virtual symbolic link for FB SDK for buddybuild
mkdir ~/Documents  
ln -s $BUDDYBUILD_WORKSPACE/ios/libs/FacebookSDK ~/Documents/FacebookSDK

@lepouya lepouya merged commit deb0a6b into facebookarchive:master Oct 5, 2017
@arv arv deleted the xcode-inherited branch October 7, 2017 00:58
@sibelius
Copy link

@arv how can we configure an app to avoid having FacebookSDK on ~/Documents?

@arv
Copy link
Contributor Author

arv commented Oct 23, 2017

@sibelius I haven't worked on this project for a few months now... but if I remember correctly you add the search path in your main project in xcode and then subprojects (like fbsdk) will also look there for the libraries.

@jemise111
Copy link

@sibelius Were you ever able to get it working? I tried adding the path to my FacebookSDK in Framework Search Paths in my main project but my app still wouldn't build. I had to use @jamesjara's symlink trick (which worked like a charm, but would be nice to get rid of)

@sibelius
Copy link

image

we got it working copying .frameworks files to xcode project

@dwilt
Copy link

dwilt commented Jun 11, 2018

This has screwed me on multiple projects. It's totally ridiculous to install a plug-in on a project to a local folder on their computer when there are multiple developers on a project

@dwilt
Copy link

dwilt commented Jun 11, 2018

Actually, CocoaPods saved the day on this one. Removed the frameworks files and then updated our Podfile:

pod 'FBSDKCoreKit'
pod 'FBSDKLoginKit'
pod 'FBSDKShareKit'

cd ios; pod install and worked like a charm

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants