CodeGen v2: Finish polymorphic inheritance support #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajor
force-pushed
the
type-graph-polymorphic-inheritance
branch
from
6607008 to
79b045e
Compare
ajor
force-pushed
the
type-graph-polymorphic-inheritance
branch
from
79b045e to
be562f5
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently broken because the Class-IDs generated by CodeGen v1 and CodeGen v2 do not match, and TreeBuilder only understands CodeGen v1's IDs.
CodeGen v2 fixes a number of issues with the polymorphic inheritance support, however, so I don't want to force it into using the old IDs.
TODO: Add tests for polymorphic inheritance with namespaces - this was broken in v1 but should work now