Validate CD Step at Run instead of Validate #519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoboticPrism
requested review from
d3sch41n,
cedowens,
d0n601 and
CrimsonK1ng
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D65831540 |
Summary: Because TTPForge runs validations on TTP load, and we validate our target directory in the Validate action, the CD step will validate the existence of its target directory at TTP load. This means that if you create your target directory as part of your TTP, your CD step will fail because the directory does not exist yet. By moving the check to the run step, we will now hold off on validating the directory's existence until the CD step is run, allowing previous steps to create the target directory. Reviewed By: inesusvet Differential Revision: D65831540
RoboticPrism
force-pushed
the
export-D65831540
branch
from
ee85ef6 to
20fe6b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65831540 |
|
This pull request has been merged in 102c30c. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Because TTPForge runs validations on TTP load, and we validate our target directory in the Validate action, the CD step will validate the existence of its target directory at TTP load. This means that if you create your target directory as part of your TTP, your CD step will fail because the directory does not exist yet.
By moving the check to the run step, we will now hold off on validating the directory's existence until the CD step is run, allowing previous steps to create the target directory.
Differential Revision: D65831540