Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enable example_compiler_gym_service unit tests in CI #699

Conversation

mostafaelhoushi
Copy link
Contributor

Let's do things one step at a time.
In this PR I checked out one file from https://github.com/facebookresearch/CompilerGym/pull/642/files# that doesn't require external files, binaries, or benchmarks and making sure it passes in CI.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2022
@mostafaelhoushi mostafaelhoushi changed the title enable example_compiler_gym_service unit tests in CI enable example_compiler_gym_service unit tests in CI Jun 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #699 (977c64a) into development (9ad5fbb) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #699   +/-   ##
============================================
  Coverage        88.64%   88.64%           
============================================
  Files              131      131           
  Lines             7926     7926           
============================================
  Hits              7026     7026           
  Misses             900      900           
Impacted Files Coverage Δ
compiler_gym/views/observation_space_spec.py 82.85% <0.00%> (-2.86%) ⬇️
compiler_gym/views/observation.py 97.29% <0.00%> (-2.71%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 87.83% <0.00%> (-2.03%) ⬇️
compiler_gym/envs/llvm/datasets/cbench.py 79.42% <0.00%> (-1.09%) ⬇️
compiler_gym/envs/gcc/service/gcc_service.py 97.06% <0.00%> (+0.36%) ⬆️
compiler_gym/service/connection.py 78.66% <0.00%> (+1.00%) ⬆️
compiler_gym/spaces/reward.py 80.70% <0.00%> (+7.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad5fbb...977c64a. Read the comment docs.

@mostafaelhoushi
Copy link
Contributor Author

@ChrisCummins : this CI seems to pass. Can we merge it? It just copied the env_tests.py unit tests to a file that can run in test-cmake-linux.

Before this PR, those test cases are not covered by CI.

@mostafaelhoushi
Copy link
Contributor Author

The CI jobs that are red are not related to this PR

@ChrisCummins
Copy link
Contributor

LGTM thanks @mostafaelhoushi!

@ChrisCummins ChrisCummins merged commit 1f587ac into facebookresearch:development Jun 9, 2022
This was referenced Nov 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants