fix bug in computation aware latency #96
Conversation
Fixed a bug where non-ca latency (e.g. AL) and ca latency (e.g. AL_CA) results are consistent when using --computation-aware.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
| latency_scorers[name] = get_scorer_class("latency", name).from_args(args) | ||
| latency_args=deepcopy(args) | ||
| latency_args.computation_aware=False | ||
| latency_scorers[name] = get_scorer_class("latency", name).from_args(latency_args) |
There was a problem hiding this comment.
Is this line always setting latency_args.computation_aware as false?
There was a problem hiding this comment.
Yes, this line is for creating non-ca latency, so computation_aware should be set to False. Line 290 is used to determine whether ca latency needs to be created based on the incoming parameters (--computation-aware).
We have tested it on simultaneous text-to-text speech-to-text and speech-to-text tasks, and can partially solve the bug when using --computation-aware.
|
Hi @zhangshaolei1998 thank you so much for the PR and sorry for the late response. |
Fixed a bug where non-ca latency (e.g. AL) and ca latency (e.g. AL_CA) results are consistent when using --computation-aware.