conditionally include __declspec to function definition to fix Window… #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have easy access to a Windows machine to test this, but it doesn't break anything on my local unix machine, so why not :) Thanks for the fix, I'll push a new release once this is merged. |
There was a problem hiding this comment.
@myleott is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 6, 2020
#1584) Summary: …s DLL exports. # Before submitting - [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [x] Did you read the [contributor guideline](https://github.com/pytorch/fairseq/blob/master/CONTRIBUTING.md)? - [x] Did you make sure to update the docs? - [x] Did you write any new necessary tests? ## What does this PR do? Fixes #292 ☝️ technically this issue should remain open ## PR review Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged. ## Did you have fun? 👍 Pull Request resolved: #1584 Differential Revision: D19289792 Pulled By: myleott fbshipit-source-id: 96af49e2ed808dde3f682906bc2d6e074b522c39
|
@myleott thanks! I tested it both on my local copy and on a fresh VM, so I'm cautiously optimistic it works. 😄 looking forward to either 0.9.1 or 0.10.0! |
moussaKam
pushed a commit
to moussaKam/language-adaptive-pretraining
that referenced
this pull request
Sep 29, 2020
facebookresearch#1584) Summary: …s DLL exports. # Before submitting - [x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements) - [x] Did you read the [contributor guideline](https://github.com/pytorch/fairseq/blob/master/CONTRIBUTING.md)? - [x] Did you make sure to update the docs? - [x] Did you write any new necessary tests? ## What does this PR do? Fixes facebookresearch#292 ☝️ technically this issue should remain open ## PR review Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged. ## Did you have fun? 👍 Pull Request resolved: facebookresearch#1584 Differential Revision: D19289792 Pulled By: myleott fbshipit-source-id: 96af49e2ed808dde3f682906bc2d6e074b522c39
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s DLL exports.
Before submitting
What does this PR do?
Fixes #292
☝️ technically this issue should remain open
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
👍