Deprecate aggregate_logging_outputs API (use reduce_metrics instead) #1611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1e324a5 we introduced
fairseq.metrics
, which allows metrics to be logged and aggregated based on their context. For example:This interface allows one to log metrics from anywhere, without having to pass the values up the call stack, resulting in a much simpler
train.py
.To make the transition smoother, we introduce
FairseqTask.reduce_metrics
andFairseqCriterion.reduce_metrics
to replace the oldaggregate_logging_outputs
method, although we provide backward compatibility for old Tasks/Criterions.