Allow k and M suffixes in IVF indexes #3812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62019941 |
|
This pull request was exported from Phabricator. Differential Revision: D62019941 |
mdouze
force-pushed
the
export-D62019941
branch
from
27358c9
to
9c0de72
Compare
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Sep 10, 2024
Summary: Pull Request resolved: facebookresearch#3812 Allows factory strings like `IVF3k,Flat` as a shorthand for 3072 centroids. The main question is whether k or M should be metric (k=1000) or power of 2 (k=1024): * pro-metric: standard, * pro-power of 2: in practice we use powers of 2 most often The suffixes ki and Mi should be used for powers of 2 but this makes the notation more heavy (which is what we wanted to avoid in the first place). So I picked power of 2. Reviewed By: mnorris11 Differential Revision: D62019941
Summary: Pull Request resolved: facebookresearch#3812 Allows factory strings like `IVF3k,Flat` as a shorthand for 3072 centroids. The main question is whether k or M should be metric (k=1000) or power of 2 (k=1024): * pro-metric: standard, * pro-power of 2: in practice we use powers of 2 most often The suffixes ki and Mi should be used for powers of 2 but this makes the notation more heavy (which is what we wanted to avoid in the first place). So I picked power of 2. Reviewed By: mnorris11 Differential Revision: D62019941
|
This pull request was exported from Phabricator. Differential Revision: D62019941 |
mdouze
force-pushed
the
export-D62019941
branch
from
9c0de72
to
e09d845
Compare
|
This pull request has been merged in d85fda7. |
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
Summary: Pull Request resolved: facebookresearch#3812 Allows factory strings like `IVF3k,Flat` as a shorthand for 3072 centroids. The main question is whether k or M should be metric (k=1000) or power of 2 (k=1024): * pro-metric: standard, * pro-power of 2: in practice we use powers of 2 most often The suffixes ki and Mi should be used for powers of 2 but this makes the notation more heavy (which is what we wanted to avoid in the first place). So I picked power of 2. Reviewed By: mnorris11 Differential Revision: D62019941 fbshipit-source-id: f547962625123ecdfaa406067781c77386017793
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allows factory strings like
IVF3k,Flatas a shorthand for 3072 centroids.The main question is whether k or M should be metric (k=1000) or power of 2 (k=1024):
pro-metric: standard,
pro-power of 2: in practice we use powers of 2 most often
The suffixes ki and Mi should be used for powers of 2 but this makes the notation more heavy (which is what we wanted to avoid in the first place).
So I picked power of 2.
Differential Revision: D62019941