Skip to content

Rebase modupdater #267

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Rebase modupdater #267

merged 1 commit into from
Jul 3, 2019

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jul 3, 2019

Based on work from https://github.com/ALovedOne and https://github.com/patschi

Needs proper testing!

@Fank Fank merged commit 28598a4 into master Jul 3, 2019
@Fank Fank deleted the modupdater-rebase branch July 3, 2019 22:42
@carlbennett
Copy link

I think these changes broke the latest version of the image. See #268 and #269

@carlbennett
Copy link

The .sh files added in this change are not marked executable (chmod +x).

carlbennett added a commit to carlbennett/factorio-docker that referenced this pull request Jul 5, 2019
@SuperSandro2000
Copy link
Member Author

@Fank If I write that it needs proper testing then I mean I did not test it properly and it shouldn't be merged. We need to communicate this better next time.

@Fank
Copy link
Member

Fank commented Jul 5, 2019

I thought people were using it so I was thinking it's maybe bugged with mod, and not making it unstable

@SuperSandro2000
Copy link
Member Author

I should have written in the description that I changed it slightly. Next time we do it better.

@carlbennett
Copy link

In my report #268, I don't have any extra mods loaded, just the base mod from Factorio that you can't disable. It was breaking on new setups too.

@SuperSandro2000
Copy link
Member Author

I will take another look at it later today and fix it.

@SuperSandro2000
Copy link
Member Author

@carlbennett Can't reproduce that. Did you pull the latest image?

@carlbennett
Copy link

@SuperSandro2000 My fixes from #272 fixed the problem. It's been fixed since yesterday. I was commenting in reply to @Fank's comment:

I thought people were using it so I was thinking it's maybe bugged with mod, and not making it unstable

I had no mods loaded besides the base mod that you have to load.

There is no present bug in the latest head on master (6ae5795).

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants