-
Notifications
You must be signed in to change notification settings - Fork 252
Rebase modupdater #267
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rebase modupdater #267
Conversation
Based on work from https://github.com/ALovedOne and https://github.com/patschi
00df2b1
to
4496a34
Compare
The .sh files added in this change are not marked executable ( |
@Fank If I write that it needs proper testing then I mean I did not test it properly and it shouldn't be merged. We need to communicate this better next time. |
I thought people were using it so I was thinking it's maybe bugged with mod, and not making it unstable |
I should have written in the description that I changed it slightly. Next time we do it better. |
In my report #268, I don't have any extra mods loaded, just the base mod from Factorio that you can't disable. It was breaking on new setups too. |
I will take another look at it later today and fix it. |
@carlbennett Can't reproduce that. Did you pull the latest image? |
@SuperSandro2000 My fixes from #272 fixed the problem. It's been fixed since yesterday. I was commenting in reply to @Fank's comment:
I had no mods loaded besides the base mod that you have to load. There is no present bug in the latest head on master (6ae5795). |
Based on work from https://github.com/ALovedOne and https://github.com/patschi
Needs proper testing!