Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Item keys #105

Merged
merged 13 commits into from
Aug 27, 2021
Merged

Item keys #105

merged 13 commits into from
Aug 27, 2021

Conversation

facundoolano
Copy link
Owner

@facundoolano facundoolano commented Aug 23, 2021 •
edited
Loading

Use an item::Key enum to identify/compare items instead of hardcoded strings. User input is translated to enum variants.

@facundoolano facundoolano changed the title fix tests/format Item keys Aug 23, 2021
@facundoolano facundoolano added this to the v1.0.0 milestone Aug 23, 2021
@facundoolano facundoolano marked this pull request as ready for review August 25, 2021 23:33
@facundoolano facundoolano merged commit 16925e7 into main Aug 27, 2021
@facundoolano facundoolano deleted the item_keys branch August 27, 2021 14:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@facundoolano