Make Fake type synonym partially applied
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GHC forces type synonyms to have all their arguments everywhere by default, `Fake` having an unnecessary argument made it harder to use - for example, `ReaderT r Fake a` was not valid code, because `Fake` was missing its argument, despite that being a valid and useful monad stack. This makes the synonym partially applied so GHC won't complain that it's missing arguments.
|
Thanks, can you update the changelog too (with a new heading |
|
Should I bump the package version as well? |
|
I think you can leave that as it is. I have plan for another minor change
in the coming week.
Also, I would be able to merge your PR in a couple of days only as I'm on
travel. Thanks!
…On Wed, 2 Mar 2022, 8:09 pm Isaac van Bakel, ***@***.***> wrote:
Should I bump the package version as well?
—
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFUBRI7FDHUBSW2ZAJTBGDU554SFANCNFSM5PULOTTQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small QoL issue I noticed when using
Fake.