Updated configuration files, added a comment to test/AddressSpec.hs file #55
Conversation
package.yaml
Outdated
| @@ -30,19 +30,27 @@ dependencies: | |||
| - base >= 4.7 && < 5 | |||
| - aeson | |||
| - random | |||
| - Cabal | |||
There was a problem hiding this comment.
I don't think cabal should be dependency ? Similar for other packages - why are they required ?
|
https://github.com/Oleksandr-Zhabenko/fakedata/actions/runs/10288712085/job/28474799400 |
I think this is good if you can remove the two binary files that are added:
|
|
I updated the .gitignore so that two binary files should not be taken by Git. |
Thanks, but those files also should be removed from this PR. |
|
I have removed the two binary files, too. |
|
Thanks, I see two things pending:
|
|
Thank you! |
|
You are welcome! |
Added hyphen into domain name checker in test/TextSpec.hs Updated configuration files, added a comment to test/AddressSpec.hs file (fakedata-haskell#55) * Update stack.yaml * Update stack.yaml * Changed yaml files to use string-random-0.1.4.3 * Changed yaml files to use text-2.0.2 * Changed yaml files * Changed yaml files * Changed yaml files * Changed yaml files * Changed yaml files * Changed package.yaml file * Changed yaml files * Added stack-lts-2* yaml files * Changed workflow yaml file * Changed workflow yaml file * Changed workflow yaml file * Changed workflow yaml file * Changed stack.yaml file * Changed stack.yaml file * Changed stack.yaml file * Changed stack.yaml file * Added commentary to test/AddressSpec.hs about the reason of random tests failures * Added commentary to test/AddressSpec.hs about the reason of random tests failures * Changed stack.yaml * Added missed data-files in fakedata.cabal * Accepted changes proposed by psibi * Accepted changes proposed by psibi for stack.yaml * Accepted changes proposed by psibi for stack.yaml * Fixed .github/workflows/tests.yml * Added dist/cabal-config-flags to .gitignore file * Removed unneeded binary files * Removed formatting and the commentary Changed domain name checker in test/TextSpec.hs Sanitized fake email domain
Updated configuration files so that the Stack LTS 20, 21, 22 are supported, added some commentary about previously noticed and probably already fixed test failures