Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): update dependency prettier to v3 #2260

Merged
merged 8 commits into from
Aug 6, 2023

Conversation

Shinigami92
Copy link
Member

This is a test PR on top of #2249
It shows what changes and what needs to be fixed

@Shinigami92 Shinigami92 added the c: dependencies Pull requests that adds/updates a dependency label Jul 17, 2023
@Shinigami92 Shinigami92 self-assigned this Jul 17, 2023
@Shinigami92
Copy link
Member Author

As prettier's function format has changed to being async and our doc-generation is written in CJS which does still not support top-level await, I need @ST-DDT for some cases to work further on this.

However, I already converted the scripts to be not based on top-level await, but there are still some problems

Another strategy could be to switch to ESM and then try to get back to this PR

@renovate renovate bot force-pushed the renovate/major-prettier branch from 66744db to d43ae16 Compare July 17, 2023 18:59
@renovate renovate bot force-pushed the renovate/major-prettier branch 10 times, most recently from caec66b to 758c876 Compare July 24, 2023 20:17
@renovate renovate bot force-pushed the renovate/major-prettier branch 6 times, most recently from 54fdfc3 to bf3b74b Compare July 31, 2023 10:09
ST-DDT
ST-DDT previously approved these changes Jul 31, 2023
@renovate renovate bot force-pushed the renovate/major-prettier branch from bf3b74b to 3548300 Compare August 1, 2023 17:05
@ST-DDT
Copy link
Member

ST-DDT commented Aug 2, 2023

@Shinigami92 Anything left to do here (Expect for changing the target branch)?

@Shinigami92
Copy link
Member Author

@Shinigami92 Anything left to do here (Expect for changing the target branch)?

checked (quickly) on my Mac, and everything seems to work
Not quite sure what you did and why we do not need prettierSync anymore, but nice 🙂👍

Feel free to rebase and merge

@renovate renovate bot force-pushed the renovate/major-prettier branch 5 times, most recently from 441837a to 2531be1 Compare August 5, 2023 12:04
@Shinigami92 Shinigami92 changed the base branch from renovate/major-prettier to next August 5, 2023 12:58
@Shinigami92 Shinigami92 dismissed ST-DDT’s stale review August 5, 2023 12:58

The base branch was changed.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #2260 (d79b3fe) into next (8345e77) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2260      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2644     2644              
  Lines      245772   245775       +3     
  Branches     1085     1082       -3     
==========================================
- Hits       244794   244784      -10     
- Misses        951      964      +13     
  Partials       27       27              
Files Changed Coverage Δ
src/utils/types.ts 0.00% <0.00%> (ø)
src/locale-proxy.ts 100.00% <100.00%> (ø)
src/modules/helpers/index.ts 99.09% <100.00%> (ø)
src/modules/helpers/unique.ts 98.70% <100.00%> (ø)
src/modules/word/filterWordListByLength.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@Shinigami92 Shinigami92 marked this pull request as ready for review August 5, 2023 13:04
@Shinigami92 Shinigami92 requested a review from a team as a code owner August 5, 2023 13:04
@Shinigami92 Shinigami92 requested review from ST-DDT and a team August 5, 2023 13:04
@ST-DDT ST-DDT requested a review from a team August 5, 2023 14:30
@Shinigami92 Shinigami92 merged commit 6b0ceca into next Aug 6, 2023
@Shinigami92 Shinigami92 deleted the shini/renovate/major-prettier branch August 6, 2023 12:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c: dependencies Pull requests that adds/updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants