Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test(mersenne): add tests for value ranges #2470

Merged
merged 21 commits into from
Dec 1, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 11, 2023

This PR adds tests asserting that our MersenneTwister19937 implementation can generate all expected values.

Partially covers #2361 with tests

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Oct 11, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 11, 2023
@ST-DDT ST-DDT requested review from a team October 11, 2023 23:36
@ST-DDT ST-DDT self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2470 (0c720dd) into next (5e0f4f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2470   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2805     2805           
  Lines      250166   250166           
  Branches     1103     1108    +5     
=======================================
+ Hits       249095   249107   +12     
+ Misses       1043     1031   -12     
  Partials       28       28           
Files Coverage Δ
src/internal/mersenne.ts 97.44% <100.00%> (+1.13%) ⬆️

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from xDivisionByZerox and a team October 15, 2023 08:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants