Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: substrings of length one #2496

Merged
merged 4 commits into from
Oct 23, 2023
Merged

chore: substrings of length one #2496

merged 4 commits into from
Oct 23, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 22, 2023

Replaces the usages of string.substring of length 1 with string[index].

This makes it easier to detect when we switch to string.at() in v9 via unicorn rule. No longer necessary.

See also:

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Oct 22, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 22, 2023
@ST-DDT ST-DDT requested review from a team October 22, 2023 15:02
@ST-DDT ST-DDT self-assigned this Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #2496 (59cfa3e) into next (2ba232e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2496      +/-   ##
==========================================
- Coverage   99.58%   99.58%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255520   255520              
  Branches     1102     1101       -1     
==========================================
- Hits       254466   254463       -3     
- Misses       1026     1029       +3     
  Partials       28       28              
Files Coverage Δ
src/modules/helpers/luhn-check.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants