Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(datatype)!: remove v8 deprecated datatype methods #2694

Merged
merged 2 commits into from
Feb 27, 2024
Merged

refactor(datatype)!: remove v8 deprecated datatype methods #2694

merged 2 commits into from
Feb 27, 2024

Conversation

Shinigami92
Copy link
Member

Remove v8 deprecated datatype methods

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: datatype Something is referring to the datatype module labels Feb 26, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Feb 26, 2024
@Shinigami92 Shinigami92 self-assigned this Feb 26, 2024
@Shinigami92 Shinigami92 requested a review from a team February 26, 2024 16:37
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 26, 2024 16:37
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (c1caa90) to head (901a701).

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2694    +/-   ##
========================================
  Coverage   99.57%   99.57%            
========================================
  Files        2815     2815            
  Lines      250304   249845   -459     
  Branches     1084     1065    -19     
========================================
- Hits       249239   248790   -449     
- Misses       1036     1055    +19     
+ Partials       29        0    -29
Files Coverage Δ
src/faker.ts 100.00% <ø> (ø)
src/modules/datatype/index.ts 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Feb 26, 2024
View reviewed changes
@Shinigami92 @ST-DDT
Update src/modules/datatype/index.ts
901a701 
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@Shinigami92 Shinigami92 requested review from ST-DDT and a team February 26, 2024 17:26
@ST-DDT ST-DDT requested a review from a team February 26, 2024 17:43
@xDivisionByZerox xDivisionByZerox merged commit 682a427 into next Feb 27, 2024
16 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-datatype branch February 27, 2024 20:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox