Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(finance)!: remove v8 deprecated finance methods #2727

Merged
merged 6 commits into from
Mar 9, 2024
Merged

refactor(finance)!: remove v8 deprecated finance methods #2727

merged 6 commits into from
Mar 9, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: finance Something is referring to the finance module labels Mar 9, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 9, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 9, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (db7aaa0) to head (7b96792).

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2727    +/-   ##
========================================
  Coverage   99.57%   99.57%            
========================================
  Files        2859     2859            
  Lines      248915   248602   -313     
  Branches      991      985     -6     
========================================
- Hits       247847   247546   -301     
+ Misses       1039     1027    -12     
  Partials       29       29
Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Shinigami92
Shinigami92 commented Mar 9, 2024
View reviewed changes
@Shinigami92 Shinigami92 marked this pull request as ready for review March 9, 2024 09:34
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 9, 2024 09:34
@Shinigami92 Shinigami92 requested review from ST-DDT and a team March 9, 2024 09:34
@ST-DDT ST-DDT requested a review from a team March 9, 2024 11:26
@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) March 9, 2024 23:54
@xDivisionByZerox xDivisionByZerox merged commit a536a9d into next Mar 9, 2024
16 checks passed
@ST-DDT ST-DDT deleted the remove-deprecated-finance-methods branch March 10, 2024 00:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @matthewmayer @ST-DDT @xDivisionByZerox