Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(locale): add Swedish(sv) counties #3154

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat(locale): add Swedish(sv) counties #3154

merged 3 commits into from
Oct 10, 2024

Conversation

johanholmerin
Copy link
Contributor

Based on the list at https://sv.wikipedia.org/wiki/Sveriges_l%C3%A4n#Lista_%C3%B6ver_Sveriges_l%C3%A4n

Note: although län is the administrative area that translates to counties, it would also be useful to have support for municipalities(kommuner), since that's whats used for addresses in Sweden.

@johanholmerin johanholmerin requested a review from a team as a code owner October 1, 2024 13:26
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 826dfcd
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/670805225f53b30008c0e758
😎 Deploy Preview https://deploy-preview-3154.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Oct 1, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (a5a6c5b) to head (826dfcd).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3154      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2796     2797       +1     
  Lines      227483   227777     +294     
  Branches      953      958       +5     
==========================================
+ Hits       227410   227702     +292     
- Misses         73       75       +2     
Files with missing lines Coverage Δ
src/locales/sv/location/county.ts 100.00% <100.00%> (ø)
src/locales/sv/location/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

ejcheng
ejcheng previously approved these changes Oct 2, 2024
@matthewmayer
Copy link
Contributor

Generally state() returns the "level 1 administrative areas" and county() returns the "level 2 administrative areas" regardless of what they are actually called in that language.

Does that make sense for sv?

@johanholmerin
Copy link
Contributor Author

Thanks @matthewmayer, that helped make things clearer. I've switched to using municipalities(kommuner) instead(based on the official list at https://skr.se/skr/tjanster/kommunerochregioner/kommunerlista.1246.html). The län were already available as state().

@xDivisionByZerox xDivisionByZerox requested review from a team October 10, 2024 11:52
@ST-DDT ST-DDT requested review from ejcheng and a team October 10, 2024 13:06
@ST-DDT ST-DDT enabled auto-merge (squash) October 10, 2024 16:47
@ST-DDT ST-DDT merged commit 67569d9 into faker-js:next Oct 10, 2024
23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants