-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(locale): add Swedish(sv) counties #3154
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3154 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2796 2797 +1
Lines 227483 227777 +294
Branches 953 958 +5
==========================================
+ Hits 227410 227702 +292
- Misses 73 75 +2
|
Generally state() returns the "level 1 administrative areas" and county() returns the "level 2 administrative areas" regardless of what they are actually called in that language. Does that make sense for sv? |
Thanks @matthewmayer, that helped make things clearer. I've switched to using municipalities(kommuner) instead(based on the official list at https://skr.se/skr/tjanster/kommunerochregioner/kommunerlista.1246.html). The län were already available as state(). |
Based on the list at https://sv.wikipedia.org/wiki/Sveriges_l%C3%A4n#Lista_%C3%B6ver_Sveriges_l%C3%A4n
Note: although län is the administrative area that translates to counties, it would also be useful to have support for municipalities(kommuner), since that's whats used for addresses in Sweden.