Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): remove eslint-define-config #3156

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

The dependency eslint-define-config is no longer required, since eslint v9. typescript-eslint ships with their own defineConfig function.

Others

Found in #3106.

@xDivisionByZerox xDivisionByZerox added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: dependencies Pull requests that adds/updates a dependency labels Oct 6, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Oct 6, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team October 6, 2024 20:21
@xDivisionByZerox xDivisionByZerox self-assigned this Oct 6, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner October 6, 2024 20:21
Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 04f7abb
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6702f12f7c130c00089d8534
😎 Deploy Preview https://deploy-preview-3156.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (34937dc) to head (04f7abb).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3156      +/-   ##
==========================================
- Coverage   99.97%   99.95%   -0.02%     
==========================================
  Files        2778     2778              
  Lines      226364   226364              
  Branches      947      940       -7     
==========================================
- Hits       226303   226273      -30     
- Misses         61       91      +30     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT merged commit d34fe02 into next Oct 7, 2024
28 checks passed
@ST-DDT ST-DDT deleted the chore/deps/remove-eslint-defined-config branch October 7, 2024 10:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants