Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(image): update overview for image module #3177

Merged

Conversation

matthewmayer
Copy link
Contributor

minor fix to clarify image category methods are removed

@matthewmayer matthewmayer requested a review from a team as a code owner October 12, 2024 13:35
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit a8b9b4c
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/670b740fb501f80008ab229f
😎 Deploy Preview https://deploy-preview-3177.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (34cf364) to head (a8b9b4c).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3177   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2798     2798           
  Lines      227806   227806           
  Branches      576      579    +3     
=======================================
+ Hits       227732   227736    +4     
+ Misses         74       70    -4     
Files with missing lines Coverage Δ
src/modules/image/index.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Oct 12, 2024
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: image Something is referring to the image module labels Oct 12, 2024
@matthewmayer matthewmayer changed the title docs(image): clarify that category methods are now removed not just deprecated docs(image): update overview for image module Oct 13, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Oct 13, 2024
@xDivisionByZerox xDivisionByZerox merged commit 60c4865 into faker-js:next Oct 13, 2024
23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c: docs Improvements or additions to documentation m: image Something is referring to the image module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants