test(animal): unroll animal test loop

[matthewmayer]

Unroll the test loop for animal module

Alternative

• test: properly convert function name to locale entry name #3197

[netlify]

✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	4ae6e0e
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/671cf480c8ee4500087c1fc9
😎 Deploy Preview	https://deploy-preview-3198.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (975098d) to head (4ae6e0e).
Report is 1 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #3198   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2804     2804           
  Lines      216974   216974           
  Branches      961      964    +3     
=======================================
+ Hits       216900   216904    +4     
+ Misses         74       70    -4     

see 1 file with indirect coverage changes

[suyashgulati]

This way makes the tests more verbose.

[matthewmayer]

It's deliberately more verbose. I feel that test code shouldn't be too "clever".

I would argue if the tests were in this format it would have been easier to see what had gone wrong when copy pasting the new test for petName. The compiler / autocomplete would guide you that you needed pet_name not petName for the definition.

[xDivisionByZerox]

I have to agree with @matthewmayer here. Test code is not supposed to be clever. Thinks like the DRY principle should not be applied to make the intend of the test more clear.

In the worst case test case isolation might even break by "clever" helper functions, since these functions are often not tested themself. While this is not the case here, I like to bring awareness of the posibilities for these situations.

[ST-DDT]

It is a for loop. I wouldn't call it clever by any means.
A for loop enforces a basic level of consistency across all methods, that a copy paste approach does not.

Ultimately, it doesn't really matter to me.
So I'm fine either way.