Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: import validator functions individually #3274

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 19, 2024

Validatorjs now supports importing validator functions individually.
Since we mostly use partial imports, we should do the same for validatorJS's functions.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: test labels Nov 19, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 19, 2024
@ST-DDT ST-DDT requested review from a team November 19, 2024 22:39
@ST-DDT ST-DDT self-assigned this Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 152da48
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/673d13afc493be0008819e5b
😎 Deploy Preview https://deploy-preview-3274.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (b0a5ad3) to head (152da48).
Report is 4 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3274   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2806     2806           
  Lines      217156   217156           
  Branches      976      976           
=======================================
+ Hits       217075   217079    +4     
+ Misses         81       77    -4     

see 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@ST-DDT ST-DDT requested a review from a team November 20, 2024 17:29
@ST-DDT ST-DDT added this pull request to the merge queue Nov 21, 2024
Merged via the queue into next with commit 56acea3 Nov 21, 2024
28 checks passed
@ST-DDT ST-DDT deleted the chore/import/validators branch November 21, 2024 22:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: test p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants